-
Notifications
You must be signed in to change notification settings - Fork 58
Conversation
bin/dsn.cmake
Outdated
@@ -413,6 +413,7 @@ function(dsn_setup_compiler_flags) | |||
add_compile_options(-Wno-unused-variable) | |||
add_compile_options(-Wno-deprecated-declarations) | |||
add_compile_options(-Wno-inconsistent-missing-override) | |||
add_compile_options(-Wno-attributes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个attribute是s2编译需要的。不加的话gcc7编译不过
really nice job! but there're still something i doubt that need to fix: first, since the second, why the
why not just:
and in the constructor you can "open the service" and don't have to split up the logic into two different functions:
|
src/dist/cli/shell/CMakeLists.txt
Outdated
@@ -1,4 +1,4 @@ | |||
set(MY_PROJ_NAME dsn.cli.tool) | |||
set(MY_PROJ_NAME cli_sh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
call this dsn_cli_shell
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个晚上我抽空改一下吧,白天没时间……
|
ok... and i will move http_service to meta_service after this committed. |
1. move cli to module dist 2. remove rpc related source code in command_manager, decouple cli command execution and command handler management. 3. move cli shell from tool to dist
0b6be21
to
5547342
Compare
@ALL has fixed based on comments |
这个pr主要干的事情:
另外: