This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
core: remove lock from c api #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengofsun
requested review from
neverchanje,
qinzuoyan,
acelyc111,
hycdong,
mentoswang,
vagetablechicken and
zhangyifan27
neverchanje
reviewed
Oct 16, 2018
include/dsn/tool-api/zlocks.h
Outdated
| */ | ||
| class zlock | ||
| class ilock; | ||
| class zlock : private boost::noncopyable |
There was a problem hiding this comment.
显式定义 noncopyable 吧也没两行代码，其实有些版本的 boost/noncopyable.hpp 会引入 boost/config.hpp，挺大的一个头文件依赖，我以前也用这个，后来就不用了
public:
// disallow copy and assign
zlock(const zlock &) = delete;
zlock &operator=(const zlock &) = delete;
|
@neverchanje 把boost的依赖删了 |
qinzuoyan
reviewed
Oct 18, 2018
include/dsn/utility/macros.h
Outdated
| #ifndef MACROS_H | ||
| #define MACROS_H | ||
|
|
||
| #define DISALLOW_COPY_AND_ASSIGN(TypeName) \ |
There was a problem hiding this comment.
这个直接放在unitity/ports.h文件中就好了，就不用单独增加一个macros.h文件了。
就像 GTEST_DISALLOW_COPY_AND_ASSIGN_ 宏也是放在 gtest-port.h 中一样。
There was a problem hiding this comment.
主要是人家的DISALLOW_COPY_AND_ASSIGN都是portable的，我们这个不是portable的……
再说，也有其他项目port和非port的宏分开啊。
anyway, 我挪过去吧
|
the disallow copy thing has fixed. @qinzuoyan @neverchanje |
qinzuoyan
approved these changes
Oct 19, 2018
neverchanje
approved these changes
Oct 20, 2018
vagetablechicken
pushed a commit
to vagetablechicken/rdsn
that referenced
this pull request
Nov 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the lock related code was scattered in different place:
now place them together, do some small modification and add some comments.