Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

utility: table_printer support output in json mode. #223

Merged
merged 9 commits into from
Mar 4, 2019

Conversation

acelyc111
Copy link
Member

No description provided.

@neverchanje

This comment has been minimized.

include/dsn/cpp/json_helper.h Outdated Show resolved Hide resolved
include/dsn/cpp/json_helper.h Outdated Show resolved Hide resolved
include/dsn/utility/output_utils.h Outdated Show resolved Hide resolved
@@ -738,7 +742,7 @@ dsn::error_code replication_ddl_client::cluster_info(const std::string &file_nam
for (int i = 0; i < resp.keys.size(); i++) {
tp.add_row_name_and_data(resp.keys[i], resp.values[i]);
}
tp.output(out, ": ");
tp.output(out);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里原始是冒号分隔,现在变成了空格分隔?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在这种单列数据的都固定使用:, 多列的使用空格 , 不可配置,实际上也不需配置

include/dsn/utility/output_utils.h Outdated Show resolved Hide resolved
include/dsn/utility/output_utils.h Outdated Show resolved Hide resolved
src/core/core/output_utils.cpp Outdated Show resolved Hide resolved
@acelyc111
Copy link
Member Author

我们的类名是下划线的,private member 名字 slash 一定是 prefixed 的,你都是 suffixed 的

fiexd

neverchanje
neverchanje previously approved these changes Feb 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants