This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
perf-counter: add remote command to get perf-counters by substr/prefi… #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Jun 16, 2019
| info.timestamp = _timestamp; | ||
| char buf[20]; | ||
| utils::time_ms_to_date_time(info.timestamp * 1000, buf, sizeof(buf)); | ||
| info.timestamp_str = buf; |
There was a problem hiding this comment.
这个当时就是为了便于阅读，所以特意放了个timestamp_str，都保留问题不大
| } | ||
| }; | ||
| iterate_snapshot(visitor); | ||
| info.result = "OK"; |
There was a problem hiding this comment.
为了和 by_regexp() 函数里面看起来比较一致
neverchanje
reviewed
Jun 17, 2019
| @@ -47,11 +47,45 @@ perf_counters::perf_counters() | |||
| { | |||
| command_manager::instance().register_command( | |||
| {"perf-counters"}, | |||
| "perf-counters - query perf counters, supporting filter by POSIX basic regular expressions", | |||
| "perf-counters [name-filter]...", | |||
| "perf-counters - query perf counters, filtered by OR of POSIX basic regular expressions", | |||
There was a problem hiding this comment.
filtered by 就对了，不需要 OR of，下面同理，加 OR of 原因是什么
| }); | ||
| }); | ||
| command_manager::instance().register_command( | ||
| {"perf-counters-by-postfix"}, |
There was a problem hiding this comment.
postfix也是后缀的意思。而且我们之前的各种用法都是postfix，那就都一致吧
neverchanje
approved these changes
Jun 17, 2019
acelyc111
approved these changes
Jun 17, 2019
This was referenced Jun 20, 2019
Closed
neverchanje
pushed a commit
that referenced
this pull request
Jun 20, 2019
neverchanje
pushed a commit
that referenced
this pull request
Jun 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…x/postfix