This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(dup): protect private log from missing when duplication is enabled #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When duplication is enabled, we check the duplication progress each time log GC performs
to ensure log files won't be deleted while they are needed.
The pseudocode:
```cpp
decree min_confirmed_decree = _duplication_mgr->min_confirmed_decree();
decree cleanable_decree = _app->last_durable_decree();
if (min_confirmed_decree >= 0 && min_confirmed_decree < cleanable_decree) {
cleanable_decree = min_confirmed_decree;
} else if (is_duplicating()) {
return;
}
```
hycdong
reviewed
Oct 15, 2019
src/dist/replication/lib/duplication/replica_duplicator_manager.cpp
Outdated
Show resolved
Hide resolved
hycdong
reviewed
Oct 15, 2019
hycdong
approved these changes
Dec 3, 2019
levy5307
approved these changes
Dec 3, 2019
acelyc111
reviewed
Dec 3, 2019
| } | ||
| }; | ||
|
|
||
| TEST_F(replica_duplicator_test, new_duplicator) { test_new_duplicator(); } |
There was a problem hiding this comment.
这种TEST里面转调一个函数的方式，是因为无法访问某些private变量吗？
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When duplication is enabled, we check the duplication progress each time log GC performs
to ensure log files won't be deleted while they are needed.
The pseudocode: