This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix: fix the bug that threads don't stop when shared_io_service is released #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
这个和timer的联系是什么？ |
timer用到了shared_io_service做io，然后创建了一个shared_io_service： 所以即使调用了_timer->cancel，shared_io_service里的thread也没有停止 |
neverchanje
changed the title
neverchanje
previously approved these changes
Dec 6, 2019
acelyc111
reviewed
Dec 6, 2019
levy5307
dismissed stale reviews from vagetablechicken and neverchanje
via
daa54e4
acelyc111
approved these changes
Dec 6, 2019
neverchanje
approved these changes
Dec 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In shared_io_service, there are some threads running. But shared_io_service doesn't have a destructor, so these threads can't be stopped.
So this pull request add a destructor for it to stop these threads.