This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(http): add uri decoder for http_server #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Dec 12, 2019
neverchanje
changed the title
levy5307
changed the title
|
通过这种方式， 能通过浏览器发送包含 |
不可以，默认情况下#之后的部分浏览器都不会传送给服务端。所以需要前端对uri先做编码，然后发送给服务端，服务端再做解码。业内都是这么做 |
neverchanje
reviewed
Dec 12, 2019
neverchanje
previously approved these changes
Dec 12, 2019
acelyc111
reviewed
Dec 12, 2019
neverchanje
previously approved these changes
Dec 13, 2019
acelyc111
reviewed
Dec 13, 2019
acelyc111
reviewed
Dec 13, 2019
acelyc111
approved these changes
Dec 13, 2019
neverchanje
approved these changes
Dec 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In http_server, there is no decoder to decode the encoded url which is received from front-end.
so, we can't get some special char, e.g., '#'.
for more detail: apache/incubator-pegasus#440