This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: move load balance related tests under another test suite #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
approved these changes
Dec 24, 2019
| @@ -217,6 +216,7 @@ class meta_service : public serverlet<meta_service> | |||
| friend class meta_test_base; | |||
| friend class meta_duplication_service; | |||
| friend class meta_http_service_test; | |||
| friend class meta_load_balance_test; | |||
There was a problem hiding this comment.
单测的friend可以使用FRIEND_TEST(test_case_name, test_name) 宏，后面的重构来做吧
There was a problem hiding this comment.
额，那就是每个 test 你都要写一个 FRIEND_TEST，其实你只需要一行 friend 就好了
hycdong
approved these changes
Dec 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to refactor the load balancing related tests and codes. This is the first step. I moved the
simple_lb_xxxtests tometa_load_balance_testto make it clear.My goal is to:
simple_lb_balanced_cure, which consists of 600+ LOC.