This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(dup): implement load_mutation #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
reviewed
Dec 27, 2019
| } | ||
|
|
||
| _log_on_disk->set_start_decree(_start_decree); | ||
| _log_on_disk->async(); |
There was a problem hiding this comment.
这里是从_start_decree开始load，一直到当前所有的都load完？
There was a problem hiding this comment.
不是所有的， 是从 _start_decree 开始， 读一个 log block， 可以了解这个 PR： #317
hycdong
reviewed
Dec 27, 2019
levy5307
approved these changes
Dec 27, 2019
hycdong
approved these changes
Dec 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
load_mutationis a part of the duplication procedure:If currently there are newly added mutations on disk, it will call
load_from_private_logto load them and goes on next stage, otherwise it sleeps 10sec like polling.