This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(thrift): add start_time_ns for structure mutation_update in thrift file #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
requested review from
levy5307,
neverchanje,
acelyc111 and
foreverneverer
acelyc111
suggested changes
Feb 5, 2020
acelyc111
previously approved these changes
Feb 5, 2020
levy5307
previously approved these changes
Feb 5, 2020
neverchanje
suggested changes
Feb 5, 2020
neverchanje
approved these changes
Feb 5, 2020
neverchanje
changed the title
levy5307
approved these changes
Feb 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #336 added a new filed called
start_time_nsfor structuremutation_update.mutation_updateis defined inreplication.thrift, and we generate.hand.cppfiles atomically by thrift. However, original pr directly added this filed in.hand.cppfile, which might be difficult to maintain.This pr add a new filed
start_time_nsfor structuremutation_updatein thrift file, and initialize it when creating this structure in functionadd_client_request.