This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor(security): refactor the send func of client_negotiation #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Sep 9, 2020
| req->msg = start_output; | ||
| send(std::move(req)); | ||
| _status = negotiation_status::type::SASL_INITIATE; | ||
| send(_status, start_output); |
There was a problem hiding this comment.
Use std::move here if you do not want a string copy.
void send(..., std::string msg) { // use value-typed string, allowing string to be move constructed.
neverchanje
approved these changes
Sep 9, 2020
acelyc111
reviewed
Sep 9, 2020
| _status = req->status = negotiation_status::type::SASL_SELECT_MECHANISMS; | ||
| req->msg = mechanism; | ||
| send(std::move(req)); | ||
| send(_status, std::move(mechanism)); |
There was a problem hiding this comment.
mechanism is a 'const &', is it movable? Is there any compile complains?
There was a problem hiding this comment.
I didn't see any compile complains. And I write a test program like this:
std::string test = "123123";
const std::string &ref_test = test;
const std::string &&r_test = std::move(ref_test);
std::cout << r_test << std::endl;
It works well.
acelyc111
approved these changes
Sep 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor the send func of client_negotiation