This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two sturctures to show split status.
split_status (in replication.thirft)
Define five split_status for partition (not_split, splitting, pausing, paused, canceling), both replica and meta will use it.
_child_gpid
to distinguish whether a replica is executing splitting, if_child_gpid.get_app_id() > 0
, the replica is splitting, otherwise not. It can only show two split status. Now, we use_split_status
to describe partition split status.split_state (in meta_data.h)
Define sturct
split_state
to show app split progress, this sturcture include splitting partition count and each split_status for those splitting partitions. Ifsplitting_count = 0
, it means current app is not splitting or has finished splitting.This sturcture is helpful to query app split progress and easier to understand. In previous implementation, when an app is executing splitting, tha ballot of not-ready child partition is
invalid_ballot
( < 0), so we should traverseapp->partitions
to check if any partition whose ballot is invalid. Now, we just check the value ofsplitting_count
.This pr also update related unit tests.