This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
feat(split): add update_child_group_partition_count #645
Merged
acelyc111
merged 4 commits into
XiaoMi:master
from
hycdong:update_child_group_partition_count
Oct 28, 2020
Merged
feat(split): add update_child_group_partition_count #645
acelyc111
merged 4 commits into
XiaoMi:master
from
hycdong:update_child_group_partition_count
Oct 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Oct 21, 2020
Comment on lines
+656
to
+663
_stub->split_replica_error_handler( | ||
_child_gpid, | ||
std::bind(&replica_split_manager::child_handle_split_error, | ||
std::placeholders::_1, | ||
"update_child_group_partition_count failed, " | ||
"wrong partition status or split status")); | ||
_replica->_primary_states.sync_send_write_request = false; | ||
parent_cleanup_split_context(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems there are some similar code on error handling paths, could you do some refactor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, split error handling has little difference in different error cases, I will refactor it after I merge split core implementation.
acelyc111
previously approved these changes
Oct 27, 2020
levy5307
reviewed
Oct 27, 2020
levy5307
approved these changes
Oct 28, 2020
acelyc111
approved these changes
Oct 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple partition split process
More partition split discussion in issue #69 and partition split design doc
This pr solves the part of seventh step of partition split, which is bold in process description.
What this pr solve
When all children have caught up its parent's state, parent will send rpc to child to let them update partition count, child will update its partition count in memory and update
.app_info
file on disk. If all children update partition_count succeed, it will send register child rpc to meta server. Besides, this pr also adds related unit tests.