This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(http): fix message buffers size check #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Nov 10, 2020
neverchanje
changed the title
acelyc111
approved these changes
Nov 10, 2020
levy5307
reviewed
Nov 11, 2020
| @@ -38,6 +38,9 @@ namespace dsn { | |||
|
|
|||
| DEFINE_CUSTOMIZED_ID(network_header_format, NET_HDR_HTTP) | |||
|
|
|||
| // Number of blobs that a message_ex contains. | |||
| #define HTTP_MSG_BUFFERS_NUM 4 | |||
There was a problem hiding this comment.
I think const uint8_t is better here
There was a problem hiding this comment.
Using constexpr or macro is basically the same, but using const is not a good practice, because the var is loaded in runtime.
neverchanje
approved these changes
Nov 11, 2020
zhangyifan27
pushed a commit
to zhangyifan27/rdsn
that referenced
this pull request
Nov 11, 2020
hycdong
added a commit
that referenced
this pull request
Dec 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous pr #593, http server can parse content-type of HTTP request. The incoming http request will parse into message_ex structure, msg->buffers[3] indicate the content-type, the msg->buffers will be resized as 4. When parsing message into http _request, the size of buffers will be checked. However, function
parsestill consider the right size of buffers is 3, it will reject all requests. This pull request fix it, add BUFFER_SIZE and update related unit tests.