This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix: local_service compile error loading file metadata #666
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compilation error
This error seems not our fault, it's rapidjson to blame, considering it's been 4 years till its latest release (1.1.0).
So I replace it with nlohmann::json where local_service metadata converts to json.
I didn't figure out the true cause of this problem. Also, no other places using rapidjson were warned by gcc9.
As
NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE
provides so much powerful sugar to replaceDEFINE_JSON_SERIALIZATION
, I don't have the drive to dig into the root cause.