This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(security): treat negotiation succeed if server is old version #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
previously approved these changes
Dec 17, 2020
neverchanje
previously approved these changes
Dec 17, 2020
foreverneverer
previously approved these changes
Dec 17, 2020
…ix-handle-response
levy5307
dismissed stale reviews from foreverneverer, neverchanje, and acelyc111
via
89e17ac
foreverneverer
approved these changes
Dec 17, 2020
neverchanje
approved these changes
Dec 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you rolling_update a cluster, if the new config set enable_auth = true. The new version server will send negotiation message to the server which has old version. And it will return
ERR_HANDLER_NOT_FOUNDto the new version server, so the negotiation will always fail.