Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix(security): remove mandatory_auth on client side #708

Merged
merged 2 commits into from
Dec 25, 2020

Conversation

levy5307
Copy link
Contributor

@levy5307 levy5307 commented Dec 24, 2020

remove mandatory_auth on client side, keep same with java client.

For on_rpc_send_msg function, there are two cases when mandatory_auth is false:

  1. enable_auth = false. In this case, the on_rpc_send_msg joint point will not be added to on_rpc_send_message. So this function will not be excuted.
  2. enable_auth = true. In this case, I think we should send nothing before negotiation succeed. So this rule is broken in previous implementation if we don't remove the mandatory_auth.

So I remove mandatory_auth in this pull request, making it a server-side config.

@levy5307 levy5307 changed the title refactor(security): remove mandatory_auth on client side fix(security): remove mandatory_auth on client side Dec 25, 2020
@levy5307 levy5307 marked this pull request as draft December 25, 2020 06:34
@levy5307 levy5307 marked this pull request as ready for review December 25, 2020 07:50
@levy5307 levy5307 merged commit 37a13a9 into XiaoMi:master Dec 25, 2020
zhangyifan27 pushed a commit to zhangyifan27/rdsn that referenced this pull request Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants