This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: reimplement join point with less code #711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we have 600+ lines of code for
join_point
, which is a quite simple class but with a very bloated code.Now, after this refactoring, it merely has 100+ LOC (including comments).
The interfaces of
join_point
were mostly unchanged, except for those that don't have any usages. So as you can see, although this class was reimplemented thoroughly, there's no other module affected.Besides, the original implementation has memory leaks, reported by asan. The current one is leak-free.