This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat: add read limiter for hdfs #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
added
the
type/config-change
levy5307
reviewed
Jan 6, 2021
levy5307
previously approved these changes
Jan 6, 2021
levy5307
approved these changes
Jan 7, 2021
foreverneverer
approved these changes
Jan 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr solves
This pull request adds folly read limiter for hdfs, different from fds implementation, this pr uses
BasicDynamicTokenBucketprovided by folly to make it thread-safe to update limiter size dynamically.Test
I depoly one server supporting limiter(100M), the rest servers don't support limiter executing bulk load from hdfs, the result like the graph shows:
I also update limiter size dynamically: 100M -> 200M -> 50M
Config changed