This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(split): add query split status interface #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Feb 1, 2021
neverchanje
approved these changes
Feb 1, 2021
acelyc111
reviewed
Feb 2, 2021
Comment on lines
+305
to
+307
| response.err = app == nullptr ? ERR_APP_NOT_EXIST : ERR_APP_DROPPED; | ||
| response.__set_hint_msg(fmt::format( | ||
| "app({}) {}", app_name, response.err == ERR_APP_NOT_EXIST ? "not existed" : "dropped")); |
There was a problem hiding this comment.
Seems there are many code like app == nullptr ? ERR_APP_NOT_EXIST : ERR_APP_DROPPED and response.err == ERR_APP_NOT_EXIST ? "not existed" : "dropped", use macros to simplify these code? You can do that in another PR.
acelyc111
approved these changes
Feb 2, 2021
zhangyifan27
pushed a commit
to zhangyifan27/rdsn
that referenced
this pull request
Feb 3, 2021
zhangyifan27
pushed a commit
to zhangyifan27/rdsn
that referenced
this pull request
Feb 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add interface to query app split status.