This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(perf_counter): remove static map from counter_info #735
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In latest tests I found that pegasus server crashed when destroy a static map after called
exit()
in libc.so.6.Coredump stack is:
To avoid this we should follow google style guide
I removed the static map from
counter_info
, and loop through the arraycounter_info_ptr
to implement the methodfind_counter_type
. Because we only had 11 elements(each element has two keys) in the array, this may not lead to much performance degradation.[1] https://google.github.io/styleguide/cppguide.html#Static_and_Global_Variables