This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(backup_policy): do not try again when got fs errors #807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, if we got errors during backup process, meta would retry again and again, the backup would never stop or be disabled until backup success.
This pr marked a policy failed when got fs errors during backup, and we could disable the policy after it is marked failed.
I tested it on a real cluster, set
fds_burst_size
to 500 bytes to mock fds errors.test steps:
The backup has started but didn't finish, I checked logs in meta server:
We could disable it because the backup is failed.
Then try to query the policy:(it has been disabled)
We could enable the policy, but the backup will still fail if we don't change the burst_size.