This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(graceful_exit): adjust the destructing order #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
approved these changes
Jun 16, 2021
foreverneverer
approved these changes
Jun 16, 2021
levy5307
approved these changes
Jun 16, 2021
foreverneverer
pushed a commit
to foreverneverer/rdsn
that referenced
this pull request
Jun 22, 2021
zhangyifan27
added a commit
to zhangyifan27/rdsn
that referenced
this pull request
Jul 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See apache/incubator-pegasus#734 for coredump stack details.
The stack shows that we still want to enqueue some tasks when
task_worker_poolis destroyed.This patch explicitly specified the order in which
service_app,rpc_engineandtask_enginestop in~service_node(), which is the reverese order they start.