Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

fix(duplication): implement reset_from to fix plog loss when duplicating with learning #845

Merged
merged 30 commits into from
Jun 22, 2021

Conversation

foreverneverer
Copy link
Contributor

@foreverneverer foreverneverer commented Jun 11, 2021

@foreverneverer foreverneverer marked this pull request as ready for review June 18, 2021 02:23
@foreverneverer foreverneverer changed the title fix: implement reset_from to fix plog loss when dupliting with learning fix: implement reset_from to fix plog loss when duplicating with learning Jun 18, 2021
src/replica/mutation_log.cpp Outdated Show resolved Hide resolved
src/replica/mutation_log.cpp Outdated Show resolved Hide resolved
src/replica/mutation_log.h Outdated Show resolved Hide resolved
src/replica/replica_learn.cpp Outdated Show resolved Hide resolved
src/replica/replica_learn.cpp Outdated Show resolved Hide resolved
hycdong
hycdong previously approved these changes Jun 21, 2021
@Smityz
Copy link
Contributor

Smityz commented Jun 22, 2021

LGTM

Copy link
Contributor

@levy5307 levy5307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hycdong hycdong merged commit 76577b2 into XiaoMi:master Jun 22, 2021
foreverneverer added a commit to foreverneverer/rdsn that referenced this pull request Jun 22, 2021
zhangyifan27 pushed a commit to zhangyifan27/rdsn that referenced this pull request Jul 1, 2021
@foreverneverer foreverneverer changed the title fix: implement reset_from to fix plog loss when duplicating with learning fix(duplication): implement reset_from to fix plog loss when duplicating with learning Jul 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants