This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat: add perf counter to record dropped timeout rpc count #859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the issue pegasus#786 shows, if the in-queue time of request has already exceed its client timeout, it should not be executed, because client has already been timeout.
This pull request is add the perf-counter to record the count of those dropped requests.
I test it on onebox with printing perf-counters and set read/write timeout as 10ms, the logs are like:
The printed perf-counters are like: