Fixes a design error revealed by running on aarch64 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simply put, you cannot call wait_event_interruptible_timeout while holding a spin_lock. The reason the driver got away with this on x86 is because the hardware is somehow fast enough so that the condition is never false and hence no scheduling ever needs to occur.
|
Hi Karen if you see my comment. this tweak needs to be added in make file for 5.x kernels... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply put, you cannot call wait_event_interruptible_timeout while
holding a spin_lock. The reason the driver got away with this on
x86 is because the hardware is somehow fast enough so that the
condition is never false and hence no scheduling ever needs to
occur.