Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable lit testing in vck5000-dynamic-dma-config branch #1124

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Enable lit testing in vck5000-dynamic-dma-config branch #1124

merged 1 commit into from
Mar 13, 2024

Conversation

fifield
Copy link
Collaborator

@fifield fifield commented Mar 13, 2024

This fixes testing in https://github.com/Xilinx/mlir-aie/tree/vck5000-dynamic-dma-config branch to make test aie/reference_designs/dynamic_dma_config_add_one print PASS! with lit. Others are still TODO

eddierichter-amd
eddierichter-amd approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@eddierichter-amd eddierichter-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fifield
Copy link
Collaborator Author

fifield commented Mar 13, 2024 

********************
Unresolved Tests (2):
  AIE_REFERENCE_DESIGNS :: dynamic_dma_config_add_one_kernel/aie.mlir
  AIE_REFERENCE_DESIGNS :: dynamic_dma_config_add_one_kernel_obj_fifo/aie.mlir

********************
Failed Tests (2):
  AIE_REFERENCE_DESIGNS :: dynamic_dma_config_add_one/aie.mlir
  AIE_REFERENCE_DESIGNS :: ipu-xrt/add_one_objFifo_no_mem_tile/run.lit

@fifield fifield merged commit 40c1d4a into Xilinx:vck5000-dynamic-dma-config Mar 13, 2024
52 of 54 checks passed
@fifield fifield deleted the vck5000_lit branch March 13, 2024 16:50
@fifield fifield mentioned this pull request Mar 13, 2024
Merged
eddierichter-amd pushed a commit that referenced this pull request Mar 20, 2024
@fifield @eddierichter-amd
Enable lit testing in vck5000-dynamic-dma-config branch (#1124)
5983c89
eddierichter-amd pushed a commit that referenced this pull request Mar 22, 2024
@fifield @eddierichter-amd
Enable lit testing in vck5000-dynamic-dma-config branch (#1124)
d31bd08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddierichter-amd eddierichter-amd eddierichter-amd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fifield @eddierichter-amd