fix: ignored TWT_TOKEN env variable

[Yokann]

Hi !

Discovered this tool yesterday. I wondered why I can't pass TWT_TOKEN env variable to the CLI. It seems the variable is ignored.

I made this fix. It should deserve a test, but I don't know Rust so much.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 19.26%. Comparing base (882e816) to head (d368c95).
Report is 1 commits behind head on main.

Files	Patch %	Lines
src/handlers/config.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #592   +/-   ##
=======================================
  Coverage   19.26%   19.26%           
=======================================
  Files          41       41           
  Lines        5086     5086           
=======================================
  Hits          980      980           
  Misses       4106     4106           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Xithrius]

Hi! Thanks for the PR. Don't worry about the failing CI on formatting, I'll be testing this just on functionality.

[Xithrius]

I'm not really seeing what your diff does to fix the bug that you were experiencing. You changed the control flow a little bit, but the logic for checking and setting the environment variable is done before the changes you made.

The section that you did change deals with the error handling, but not any actual writing to the token environment variable that is used to log into the IRC at config.twitch.token.

Perhaps it's something to do with exporting TWT_TOKEN on your system. What shell are you using, and how are you setting the environment variable? I am unable to reproduce via export "<token>" && twt.

[Yokann]

Hi,
If I tried to pass the variable as environment variable, I get this error. So I looked into the checking part.

Twitch config section is missing one or more of the following: username, channel, token.

I don't think the error is relative to a shell, as I got the same result from bash or zsh on Arch.

Here is the part of my script I am trying to run. The $ACCESSTOKEN is valid, tested directly in the twt config file.

streamlink -Q "--twitch-api-header=Authorization=Bearer $ACCESSTOKEN" https://www.twitch.tv/$selected_channel &
TWT_TOKEN="oauth:$ACCESSTOKEN" twt -c $selected_channel

Let me do some recheck. It's weird.

[Yokann]

I also tried export TWT_TOKEN=*****. It doesn't change anything.

[Xithrius]

What version of twitch-tui are you on? I tried the same command as yours with my token, seemed to work fine.

[Yokann]

I'm using twitch-tui 2.6.7 and rust 1.78.0. I did a fresh install on a different machine (Macbook) and I've got the same issue.

Fun story, and that's why I thought my PR fix the issue, when I run from the source, it works totally fine

TWT_TOKEN=*** cargo run

but if I run it with the binary, the environment variable is ignored. :mindblowing:

TWT_TOKEN=*** ./target/debug/twt

[Xithrius]

Do the changes in this PR fix the issue you're experiencing?

[Yokann]

I updated the PR and changed the way the code get the variable, and everything seems fine now.
Maybe an issue with the option_env macro.

[Xithrius]

Ah, yeah that might just fix it. I'll test it very soon. I have a feeling it's to do with option_env's way of checking for the variable:

Optionally inspects an environment variable at compile time.

[Xithrius]

I've tried a bunch of different ways to set the environment variable, I haven't had any problems with the current state of this PR.

I'll get out a version such that the hotfix is available.

Thank you!

[Xithrius]

Available in https://github.com/Xithrius/twitch-tui/releases/tag/v2.6.8