Correctly handle paginated response for twitch user emotes #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nogesma
force-pushed
the
fix/twitch-subscriber-emotes
branch
from
5470d6b to
fbd93fc
Compare
|
I'll be able to test later today (6 hours or so), thank you very much for the quick PR. |
Xithrius
reviewed
Jun 21, 2024
There was a problem hiding this comment.
Alright, I've tested it out, here's what I've found:
- Going to my own channel where I should have access to all emotes shows an empty list in the emote picker.
- Going to someone else's channel shows their emotes, but no global.
- I am subscribed to one channel, but no subscriber emotes from said channel show up in any place.
Although I understand you disabled global fetching from get_global_emotes, it doesn't seem to be handled by get_user_emotes's response.
Please let me know if I am misunderstanding any functionality.
|
Please make sure your token has the |
Xithrius
approved these changes
Jun 22, 2024
|
Ah sorry I already did it, it's good to merge. |
|
Very cool. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #615
This is a very quick fix, let me know if it works.
I disabled fetching global emotes for twitch as it should now be handled by the
get_user_emotespart.If it works correctly I'll do a bit of cleanup before merging.