[79_6] Performance tuning on vertex_occurrences in link.cpp #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingkaimori
reviewed
Sep 12, 2024
| @@ -57,15 +63,22 @@ unregister_pointer (string id, observer which) { | |||
|
|
|||
| void | |||
| register_vertex (tree v, soft_link ln) { | |||
| list<soft_link>& l= vertex_occurrences (v); | |||
| l = list<soft_link> (ln, l); | |||
| if (vertex_occurrences->contains (v)) { | |||
There was a problem hiding this comment.
为什么这里要判断v是否是vertex_occurrences的键？如果hashmap不包含对应的键，会原位构造对应的参数，然后返回引用。如果hashset没有默认初始化函数，可以在初始化vertex_occurrences的时候传个初始对象进去
There was a problem hiding this comment.
用原来的写法，编辑器直接卡死了。所以用了这种朴素的写法。
|
这块代码看起来没有问题。有经过测试，其他调用这块的代码，可以正常运行吗？ |
Oyyko
reviewed
Sep 12, 2024
| hashmap<tree, list<soft_link>> vertex_occurrences; | ||
| hashmap<string, int> type_count (0); | ||
| static int | ||
| hash (soft_link l) { |
There was a problem hiding this comment.
hashset<soft_link> 需要提供一个 hash函数
通过打开文档测试的，我尝试加一下集成测试 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Use hashset instead list for faster insertion and removal.
How to test your changes?
Use Goldfish.tmu as the test doc: https://github.com/LiiiLabs/goldfish/blob/main/Goldfish.tmu