#4366 make 'inline' mode the default

xpra/client/base/client.py

@@ -520,7 +520,7 @@ def compressed_wrapper(self, datatype, data, level=5, **kwargs) -> compression.C
                 # the compressed version is smaller, use it:
                 return cw
         # we can't compress, so at least avoid warnings in the protocol layer:
-        return compression.Compressed(f"raw {datatype}", data, can_inline=True)
+        return compression.Compressed(f"raw {datatype}", data)
 
     def send(self, packet_type: str, *parts: PacketElement) -> None:
         packet = (packet_type, *parts)

xpra/client/base/stub_client_mixin.py

@@ -99,7 +99,7 @@ def compressed_wrapper(self, datatype, data, level=5, **kwargs) -> Compressed:
         subclasses should override this method.
         """
         assert level >= 0
-        return Compressed("raw %s" % datatype, data, can_inline=True)
+        return Compressed("raw %s" % datatype, data)
 
     def init_authenticated_packet_handlers(self) -> None:
         """

xpra/client/mixins/audio.py

@@ -546,8 +546,8 @@ def send_audio_data(self, audio_source, data: bytes,
                         metadata: dict, packet_metadata: Sequence[SizedBuffer]) -> None:
         codec = audio_source.codec
         # tag the packet metadata as already compressed:
-        pmetadata = Compressed("packet metadata", packet_metadata, can_inline=True)
-        packet_data = [codec, Compressed(codec, data, True), metadata, pmetadata]
+        pmetadata = Compressed("packet metadata", packet_metadata)
+        packet_data = [codec, Compressed(codec, data), metadata, pmetadata]
         self.send("sound-data", *packet_data)
 
     def send_audio_sync(self, v: int) -> None:

xpra/codecs/argb/encoder.py

@@ -108,7 +108,7 @@ def encode(coding: str, image, options: dict) -> tuple[str, Compressed, dict[str
         # can't pass a raw buffer to rencodeplus,
         # and even if we could, the image containing those pixels may be freed by the time we get to the encoder
         algo = "not"
-        cwrapper = Compressed(coding, rgb_transform.pixels_to_bytes(pixels), True)
+        cwrapper = Compressed(coding, rgb_transform.pixels_to_bytes(pixels))
     if pixel_format.find("A") >= 0 or pixel_format.find("X") >= 0:
         bpp = 32
     else:

xpra/net/compression.py

@@ -145,7 +145,7 @@ def get_compressor(name) -> Callable:
 class Compressed:
     __slots__ = ("datatype", "data", "can_inline")
 
-    def __init__(self, datatype: str, data: SizedBuffer | Sequence, can_inline=False):
+    def __init__(self, datatype: str, data: SizedBuffer | Sequence, can_inline=True):
         if not data and not isinstance(data, Sequence):
             raise ValueError(f"missing compressed data, got {data!r} ({type(data)})")
         self.datatype = datatype
@@ -201,7 +201,7 @@ def compress(self):
 def compressed_wrapper(datatype, data, level=5, can_inline=True, **kwargs) -> Compressed:
     size = len(data)
 
-    def no():
+    def no() -> Compressed:
         return Compressed(f"raw {datatype}", data, can_inline=can_inline)
 
     if size <= MIN_COMPRESS_SIZE:

xpra/server/proxy/instance_base.py

@@ -370,7 +370,7 @@ def process_client_packet(self, proto, packet: PacketType) -> None:
         self.queue_server_packet(packet)
 
     def compressed_marker(self, packet: PacketType, index: int, description: str) -> PacketType:
-        return replace_packet_item(packet, index, Compressed(description, packet[index], can_inline=False))
+        return replace_packet_item(packet, index, Compressed(description, packet[index]))
 
     def queue_server_packet(self, packet: PacketType) -> None:
         log("queueing server packet: %s (queue size=%s)", packet[0], self.server_packets.qsize())

xpra/server/source/audio.py

@@ -359,8 +359,8 @@ def new_audio_buffer(self, audio_source, data: bytes,
     def send_audio_data(self, audio_source, data: bytes, metadata: dict,
                         packet_metadata: Sequence[SizedBuffer]) -> None:
         # tag the packet metadata as already compressed:
-        pmetadata = Compressed("packet metadata", packet_metadata, can_inline=True)
-        packet_data = [audio_source.codec, Compressed(audio_source.codec, data, True), metadata, pmetadata]
+        pmetadata = Compressed("packet metadata", packet_metadata)
+        packet_data = [audio_source.codec, Compressed(audio_source.codec, data), metadata, pmetadata]
         sequence = audio_source.sequence
         if sequence >= 0:
             metadata["sequence"] = sequence

xpra/server/source/windows.py

@@ -287,7 +287,7 @@ def do_send_cursor(self, delay, cursor_data, cursor_sizes, encoding_prefix="") -
                 img.save(buf, "PNG")
                 pngdata = buf.getvalue()
                 buf.close()
-                cpixels = Compressed("png cursor", pngdata, can_inline=True)
+                cpixels = Compressed("png cursor", pngdata)
                 encoding = "png"
                 if SAVE_CURSORS:
                     filename = f"raw-cursor-{serial:x}.png"