Skip to content

Commit

Permalink
detect buggy Debian servers and warn the user instead of failing to p…
Browse files Browse the repository at this point in the history
…arse the attributes they've messed up

git-svn-id: https://xpra.org/svn/Xpra/trunk@25649 3bb7dfac-3a0b-4e04-842a-767bc560f471
  • Loading branch information
totaam committed Mar 15, 2020
1 parent 0a2b405 commit d5dcf13
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions src/xpra/client/mixins/serverinfo_mixin.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

from xpra.version_util import version_compat_check
from xpra.os_util import bytestostr
from xpra.util import typedict
from xpra.util import typedict, get_util_logger
from xpra.client.mixins.stub_client_mixin import StubClientMixin
from xpra.exit_codes import EXIT_INCOMPATIBLE_VERSION

Expand Down Expand Up @@ -35,7 +35,12 @@ def parse_server_capabilities(self, c : typedict) -> bool:
self._remote_uuid = c.strget("uuid")
self._remote_version = c.strget("build.version", c.strget("version"))
self._remote_revision = c.strget("build.revision", c.strget("revision"))
self._remote_modifications = c.intget("build.local_modifications", 0)
mods = c.rawget("build.local_modifications")
if mods and str(mods).find("dfsg")>=0:
get_util_logger().warn("Warning: the xpra server is running a buggy Debian version")
get_util_logger().warn(" those are usually out of date and unstable")
else:
self._remote_modifications = c.intget("build.local_modifications", 0)
self._remote_build_date = c.strget("build.date")
self._remote_build_time = c.strget("build.time")
self._remote_hostname = c.strget("hostname")
Expand Down

0 comments on commit d5dcf13

Please sign in to comment.