Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify build file #3577

Closed
totaam opened this issue Jul 15, 2022 · 1 comment
Closed

simplify build file #3577

totaam opened this issue Jul 15, 2022 · 1 comment
Labels
enhancement New feature or request packaging

Comments

@totaam
Copy link
Collaborator

totaam commented Jul 15, 2022

At 2.6kloc, it's just really hard to read and maintain.
At the very least, refactor the almost identical Cython blocks such as this one:

if jpeg_encoder_ENABLED:
       jpeg_pkgconfig = pkgconfig("libturbojpeg")
       add_cython_ext("xpra.codecs.jpeg.encoder",
               ["xpra/codecs/jpeg/encoder.pyx"],
               **jpeg_pkgconfig)
``
@totaam totaam added enhancement New feature or request packaging labels Jul 15, 2022
totaam added a commit that referenced this issue Jul 15, 2022
totaam added a commit that referenced this issue Jul 15, 2022
totaam added a commit that referenced this issue Jul 15, 2022
totaam added a commit that referenced this issue Jul 18, 2022
totaam added a commit that referenced this issue Jul 18, 2022
totaam added a commit that referenced this issue Jul 18, 2022
totaam added a commit that referenced this issue Jul 18, 2022
totaam added a commit that referenced this issue Jul 18, 2022
totaam added a commit that referenced this issue Jul 18, 2022
totaam added a commit that referenced this issue Jul 18, 2022
totaam added a commit that referenced this issue Jul 19, 2022
totaam added a commit that referenced this issue Jul 19, 2022
totaam added a commit that referenced this issue Jul 19, 2022
@totaam
Copy link
Collaborator Author

totaam commented Jul 25, 2022

See also 3b40fc0

This will do for now, more will be done as part of #3592.

@totaam totaam closed this as completed Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request packaging
Projects
None yet
Development

No branches or pull requests

1 participant