Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Error struct accessible outside the crate #35

Merged
merged 1 commit into from
Apr 15, 2023

Conversation

acanthite1855
Copy link
Contributor

@acanthite1855 acanthite1855 commented Apr 15, 2023

Because the Error is not accessible from outside the crate I cannot implement From (either manually or via thiserrors #[from] and the like).
Without this I'm basically forced to to_string the error and wrap that with my own error type.

Not that I need more than just a string to output the description of the error, but it's a little bit annoying that I have to do it manually, while #[from] could do everything for me.

@Xuanwo
Copy link
Owner

Xuanwo commented Apr 15, 2023

Thanks a lot!

@Xuanwo Xuanwo merged commit f0dd84d into Xuanwo:main Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants