Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix semester deletion #886

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

Tevetron
Copy link
Collaborator

this change links our semester_info data table and our courses data table so that deleting a semester from our database removes the corresponding class information

@becausej becausej self-requested a review November 1, 2024 20:31
@becausej becausej self-assigned this Nov 1, 2024
Copy link
Collaborator

@becausej becausej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't completely understand, but I've confirmed it doesn't break yacs

@Tevetron
Copy link
Collaborator Author

Tevetron commented Nov 5, 2024

I made an additional change to properly create the foreign key relationship between the semester_info and course tables.

added get requests for finals by semester, also added cache for the finals table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants