Add Guitar Praise DLC icon, and re-ID Guitar Praise Expansion 1 as a separate thing #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guitar Praise currently has the source
praisefor its on-disc songs,praisedlcfor Expansion Pack 1 (with no icon), andstryperfor the Stryper expansion pack. However, there was also a 5-song pack that was only obtainable via download. Those songs would be considered DLC, and don't fall under any of the existing source names.Expansion Pack 1 currently uses the ID that would logically fit a Guitar Praise DLC source, so I re-ID'd it to
praiseexpansionand gavepraisedlcto a new Guitar Praise DLC source. I was able to make a Guitar Praise DLC icon following the design language of the other DLC sources. This doesn't include an icon for the expansion pack, which I don't have a clear vision for.