Accept slash-t for tab as delimiter argument #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently to use a tab you must use: $ csvlens -d $'\t' ... With this change the following are also accepted: $ csvlens -d '\t' ... $ csvlens -d "\t" ...
|
It would be great if there's a flag |
|
I can see the attraction of Would the authors want to add another command line switch though? |
|
see #47 |
|
That's amusing timing, two related pull requests the same day - both trying to make it easier to work with TSV files 😀 |
|
This is great! Would you mind fixing the lint error? |
|
Thank you @peterjc and @JojiiOfficial, interesting timing indeed. And I'm going to merge both! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross reference #19, currently to use a tab you must use:
With this change the following are also accepted:
This convention is used elsewhere, including the
xsvandqsvtools:https://github.com/BurntSushi/xsv/blob/0.13.0/src/config.rs#L37
https://github.com/jqnatividad/qsv/blob/0.121.0/src/config.rs#L47