Skip to content
This repository has been archived by the owner on Apr 30, 2019. It is now read-only.

Fix concurrency issue in DataSketches metrics provider #3

Merged
merged 1 commit into from
Mar 21, 2017

Conversation

merlimat
Copy link
Collaborator

@merlimat merlimat commented Mar 3, 2017

FIx for concurrency issue across threads sending the metrics values and the thread that is swapping active and replacement when doing the collection.

Fixes apache/pulsar#258

@merlimat merlimat requested review from saandrews and rdhabalia March 3, 2017 00:06
Copy link

@rdhabalia rdhabalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rdhabalia
Copy link

@merlimat we need to cherry-pick this commit to internal repo so, it can build the jars. and once jars are built then we need to cherry-pick jar-commit to this repo(mvn-repo branch) so, it can be available in our public-repo. right?
+@revans2

@revans2
Copy link
Collaborator

revans2 commented Mar 21, 2017

@merlimat The change looks OK, I'll try to pull this in.

@revans2 revans2 merged commit 7c0cb2d into YahooArchive:yahoo-4.3 Mar 21, 2017
@revans2
Copy link
Collaborator

revans2 commented Mar 21, 2017

@merlimat I managed to merge this in. Thanks for the contribution.

@merlimat
Copy link
Collaborator Author

@revans2 Thanks, I'll update pom on pulsar repo to pick up this bk version. On the front of the 64bit ledger generation, that should be a smooth change, right?
Can there be any risk in case of "rolling back to previous version"?

@revans2
Copy link
Collaborator

revans2 commented Mar 21, 2017

@merlimat The 64 bit ledger ID generation should be totally backwards compatible until the ledger IDs roll over in ZK. At that point you cannot go back, but you would be in trouble without the change anyways.

@merlimat
Copy link
Collaborator Author

merlimat commented Mar 21, 2017

Sounds great, so no worries for "ordinary" users :)

Thanks

rdhabalia pushed a commit to rdhabalia/bookkeeper that referenced this pull request Sep 25, 2018
YahooArchive#2 renamed collection to namespace but it doesn't finish cleaning up the status code references. This pull request fixes it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants