-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds handling of recursive mappings #54
Adds handling of recursive mappings #54
Conversation
…naged object deserializer
@josepmedrano thanks! I'll take a closer look tomorrow. |
@dimazen hi, what's the status of this pull request review? |
@josepmedrano please add I've opened a respective PR in your fork. Unfortunately the tests are still failed, but I don't have time now to fix it. @dimazen ping =) |
Hello, @Antondomashnev. Sorry for such a huge delay - I was busy on the project and then totally forgot about FEM and pending PRs. Going to take a look at your PR today and merge if it is OK (it should be, I reviewed it before). Regarding failing tests: they should be fine - I've fixed Travis CI integration, however, it won't rerun existing PRs unless you'll try to push something :) Therefore I can merge @josepmedrano's changes and then your request and then merge to the master. |
@dimazen that's sounds awesome |
@Antondomashnev I have a weekend tomorrow, so decided to postpone it until tomorrow's morning (since whole day is free). Hope it is ok. (But I'm keeping FEM in mind) |
@dimazen don't worry I'm using the pod from my fork now, it's not urgent |
This PR has failing tests (fixing), I've merged it into current feature/FEM-53 branch where I'm also going to merge @Antondomashnev's changes. |
Thanks @dimazen 🚀 |
I'm planning to make a release on this weekends, that will also include documentation in headers, so thats why you don't see any new release with recursive mapping |
@Antondomashnev you can now grab 1.1 release from the CocoaPods :) |
@dimazen amazing, thanks lot =) |
As discussed on issue 53 (#53)