Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add release build and test stage for PRs #79

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

FalcoSuessgott
Copy link
Collaborator

@FalcoSuessgott FalcoSuessgott commented Jan 16, 2024

Hola, @btassone, added some CI tests so we can better check whether dependabot PRs dont break our build pipeline

@FalcoSuessgott FalcoSuessgott changed the title feat(ci): add go tests action feat(ci): add release build and test stage for PRs Jan 16, 2024
@FalcoSuessgott FalcoSuessgott marked this pull request as draft January 16, 2024 09:56
@FalcoSuessgott
Copy link
Collaborator Author

I believe, since I opened that PR from my fork I cannot merge it on my own. Perhaps I can merge PRs directly, since I'm now a collaborator :p

Copy link
Contributor

@btassone btassone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a few questions before I approved.

hooks:
# This will check plugin compatibility against latest version of Packer
post:
- go install github.com/hashicorp/packer-plugin-sdk/cmd/packer-sdc@latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this section being removed?

@@ -21,14 +22,26 @@ jobs:
name: Set up Go
uses: actions/setup-go@v2
with:
go-version: "1.21"
go-version: "1.16"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were there issues with the go version here being set to 1.21 and the version in go.mod being different (it's 1.16 there)?

GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# if no tag test release build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Contributor

@btassone btassone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a minor change to the go version to 1.21 tests now pass again. Good work!

@btassone btassone merged commit 252c245 into YaleUniversity:master Feb 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants