Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make VT requests multithreaded #30

Closed
YamatoSecurity opened this issue Aug 19, 2023 · 6 comments · Fixed by #33 or #34
Closed

Make VT requests multithreaded #30

YamatoSecurity opened this issue Aug 19, 2023 · 6 comments · Fixed by #33 or #34
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@YamatoSecurity
Copy link
Collaborator

I would like to make the VT requests (vt-domain-lookup, vt-hash-lookup, vt-ip-lookup commands) multithreaded to make VT lookups much faster.
Also, I would like to use Puppy for HTTPS requests if possible as it does not require including extra DLLs, etc... However, we need to test that it works on Win, mac and linux first.

@fukusuket Are you interested in this?

@fukusuket
Copy link
Collaborator

@YamatoSecurity
Thank you for the mention :) Yes, I would love to implement it!💪 I would like to start by studying Nim programming ^^

@YamatoSecurity YamatoSecurity added the enhancement New feature or request label Aug 19, 2023
@YamatoSecurity
Copy link
Collaborator Author

@fukusuket Oh great, thanks!

@fukusuket
Copy link
Collaborator

@YamatoSecurity
I have a question! What's the main reason you want to use Puppy if we can?
(Does it have anything to do with parallelization?)

@YamatoSecurity
Copy link
Collaborator Author

@fukusuket It has nothing to do with parallelization. Right now we have to include extra DLLs for Windows and compile with -d:ssl but those are not necessary with Puppy. So it is not such a high priority and if it makes takajo less compatible for some reason or causes problems then we can leave it as is but would like to remove as much dependencies as possible.

@fukusuket
Copy link
Collaborator

I see, I understand that we can remove the extra dependency :) I will try Puppy💪

@fukusuket
Copy link
Collaborator

Puppy's compile error(with Nim 2.0.0) was fixed by merging the following PR ^^

@fukusuket fukusuket linked a pull request Aug 26, 2023 that will close this issue
@fukusuket fukusuket linked a pull request Sep 3, 2023 that will close this issue
@hitenkoku hitenkoku added this to the 2.1.0 milestone Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
3 participants