Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nim 2.0.0 compile error caused by _ variables #107

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

fukusuket
Copy link
Contributor

Hello, Thank you so much for maintaining tool :) I created a fix PR for the issue below.

In Nim 2.0.0 released on August 1st, it seems that _ can no longer be used as a variable due to the following changes.

Currently, only the macOS code had _ usage, so I replaced it with x.

For this pull request, I have confirmed following:

  • Successful compilation with Nim 2.0.0 and 1.6.14
  • README some sample code works

I would appreciate it if you could review.

Regards,

@treeform treeform merged commit 01abb06 into treeform:master Aug 25, 2023
12 checks passed
@treeform
Copy link
Owner

Thanks this is great! Got to get 2.0 ready!

@fukusuket fukusuket deleted the fix-nim-200-compile-error branch August 25, 2023 22:24
@fukusuket
Copy link
Contributor Author

Thank you so much for quick review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to build with nim 2.0.0
2 participants