Skip to content

Commit

Permalink
Fix CI
Browse files Browse the repository at this point in the history
Signed-off-by: Igoshev, Iaroslav <iaroslav.igoshev@intel.com>
  • Loading branch information
YarShev committed Nov 13, 2023
1 parent 89c0473 commit ed566a0
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 10 deletions.
14 changes: 7 additions & 7 deletions .github/workflows/ci-notebooks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
- setup.cfg
- setup.py
- requirements/env_hdk.yml
- requirements/env_unidist.yml
- requirements/env_unidist_linux.yml
concurrency:
# Cancel other jobs in the same branch. We don't care whether CI passes
# on old commits.
Expand All @@ -29,15 +29,15 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/python-only
if: matrix.execution != 'hdk_on_native' || matrix.execution != 'pandas_on_unidist'
if: matrix.execution != 'hdk_on_native' && matrix.execution != 'pandas_on_unidist'
- uses: ./.github/actions/mamba-env
with:
environment-file: requirements/env_hdk.yml
activate-environment: modin_on_hdk
if: matrix.execution == 'hdk_on_native'
- uses: ./.github/actions/mamba-env
with:
environment-file: requirements/env_unidist.yml
environment-file: requirements/env_unidist_linux.yml
activate-environment: modin_on_unidist
if: matrix.execution == 'pandas_on_unidist'
- name: Cache datasets
Expand All @@ -49,25 +49,25 @@ jobs:
# replace modin with . in the tutorial requirements file for `pandas_on_ray` and
# `pandas_on_dask` since we need Modin built from sources
- run: sed -i 's/modin/./g' examples/tutorial/jupyter/execution/${{ matrix.execution }}/requirements.txt
if: matrix.execution != 'hdk_on_native' || matrix.execution != 'pandas_on_unidist'
if: matrix.execution != 'hdk_on_native' && matrix.execution != 'pandas_on_unidist'
# install dependencies required for notebooks execution for `pandas_on_ray` and `pandas_on_dask`
# Override modin-spreadsheet install for now
- run: |
pip install -r examples/tutorial/jupyter/execution/${{ matrix.execution }}/requirements.txt
pip install git+https://github.com/modin-project/modin-spreadsheet.git@49ffd89f683f54c311867d602c55443fb11bf2a5
if: matrix.execution != 'hdk_on_native' || matrix.execution != 'pandas_on_unidist'
if: matrix.execution != 'hdk_on_native' && matrix.execution != 'pandas_on_unidist'
# Build Modin from sources for `hdk_on_native` and `pandas_on_unidist`
- run: pip install -e .
if: matrix.execution == 'hdk_on_native' || matrix.execution == 'pandas_on_unidist'
# install test dependencies
# NOTE: If you are changing the set of packages installed here, make sure that
# the dev requirements match them.
- run: pip install pytest pytest-cov black flake8 flake8-print flake8-no-implicit-concat
if: matrix.execution != 'hdk_on_native' || matrix.execution != 'pandas_on_unidist'
if: matrix.execution != 'hdk_on_native' && matrix.execution != 'pandas_on_unidist'
- run: pip install flake8-print jupyter nbformat nbconvert
if: matrix.execution == 'hdk_on_native' || matrix.execution == 'pandas_on_unidist'
- run: pip list
if: matrix.execution != 'hdk_on_native' || matrix.execution != 'pandas_on_unidist'
if: matrix.execution != 'hdk_on_native' && matrix.execution != 'pandas_on_unidist'
- run: |
conda info
conda list
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/ci-required.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,9 @@ jobs:
architecture: "x64"
cache: "pip"
cache-dependency-path: '**/requirements-doc.txt'
# Install a working MPI implementation so mpi4py can link to it
- name: Install MPICH
run: sudo apt install libmpich-dev
- run: pip install -r docs/requirements-doc.txt
- run: cd docs && sphinx-build -T -E -W -b html . build

Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,15 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/python-only
- run: python -m pip install -e ".[all]"
# Install a working MPI implementation so mpi4py can link to it
- name: Install MPICH
run: sudo apt install libmpich-dev
- run: python -m pip install -e ".[all,mpi]"
- name: Ensure all engines start up
run: |
MODIN_ENGINE=dask python -c "import modin.pandas as pd; print(pd.DataFrame([1,2,3]))"
MODIN_ENGINE=ray python -c "import modin.pandas as pd; print(pd.DataFrame([1,2,3]))"
MODIN_ENGINE=unidist UNIDIST_BACKEND=mpi mpiexec -n 1 python -c "import modin.pandas as pd; print(pd.DataFrame([1,2,3]))"
test-internals:
needs: [lint-flake8, lint-black-isort]
Expand Down
4 changes: 3 additions & 1 deletion docs/getting_started/installation.rst
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ To install the most recent stable release run the following:
pip install -U modin # -U for upgrade in case you have an older version
Modin can be used with :doc:`Ray</development/using_pandas_on_ray>`, :doc:`Dask</development/using_pandas_on_dask>`, :doc:`Unidist</development/using_pandas_on_unidist>`, or :doc:`HDK</development/using_hdk>` engines. If you don't have Ray_, Dask_ or Unidist_ installed, you will need to install Modin with one of the targets:
Modin can be used with :doc:`Ray</development/using_pandas_on_ray>`, :doc:`Dask</development/using_pandas_on_dask>`,
:doc:`Unidist</development/using_pandas_on_mpi>`, or :doc:`HDK</development/using_hdk>` engines.
If you don't have Ray_, Dask_ or Unidist_ installed, you will need to install Modin with one of the targets:

.. code-block:: bash
Expand Down
2 changes: 1 addition & 1 deletion docs/requirements-doc.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# install current modin checkout to bring all required dependencies
.[all]
.[all,mpi]
# now install some more optional dependencies
colorama
click
Expand Down

0 comments on commit ed566a0

Please sign in to comment.