Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Challenge 5 (Unreviewed) #369

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

randdane
Copy link
Contributor

No description provided.

@randdane
Copy link
Contributor Author

I'm not sure how challenge 4 and 5 got into the same pull request. Should I delete this and resubmit it?

@randdane randdane changed the title [Python] Challenge 5 submission [Python] Challenge 5 (Unreviewed) Jan 12, 2017
@ning-y
Copy link
Contributor

ning-y commented Jan 13, 2017

@whiterd Sure. Or try:

$ git checkout python_5
$ git rm -r challenge_4/python/whiterd
$ git commit -m "Remove challenge #4"

@ning-y
Copy link
Contributor

ning-y commented Jan 13, 2017

Note: Your challenge 4 is in this pull request because it is in this, your challenge 5 branch. As you know, this shouldn't be the case, as each challenge is supposed to have its own branch. You could've produced this error in two ways (that I know off)

  1. When you started off in your branch origin/master, you already had challenge 4 in there. Therefore when you created this new branch python_5 it was included as well. However, as your challenge had not yet been merged with with this challenges/master branch, it shows up as a change in the pull request.
  2. You created the branch correctly with a clean origin/master without a challenge 4. However, you somehow merged your python 4 with origin/master. Afterwards, while on your branch python_5 you performed a git pull origin master, merging challenge 4 content into this branch.

To avoid this, simply make sure the origin/master branch is not ahead of challenges/master. Do this by only calling git pull challenges master; avoid pulling from your origin/python_n. You must also not pull anything into your origin/python_n.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants