This repository has been archived by the owner on Jun 30, 2021. It is now read-only.
issue#6: fix various potential socket leaks. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup open file descriptors when bind_sockaddr fails. Thanks to @hyperblast for reporting this issue #6
Hold up the same error checking standards as its owner :)
- evhtp_accept_socket's function definition states that 0 on success, -1 on error. This was not the case. Also evhtp_accept_socket should not close the file descriptor as it is passed as an argument, not an owner. There should be no negative effects of this change of the documentation for the function was used :D
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per issue#6, try to steady those socket leaks as well as we can for now.