Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for python 2 #51

Merged
merged 3 commits into from
Feb 12, 2020
Merged

Remove support for python 2 #51

merged 3 commits into from
Feb 12, 2020

Conversation

OiCMudkips
Copy link
Contributor

Ron-Paul_Its-Happening1

KevinHock
KevinHock approved these changes Feb 12, 2020
View reviewed changes
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🚢

🎈 🎉 🎂

There are probably a few scattered "I wouldn't have written it this way if not for Python 2 compatibility" snippets, but we can pick those off as we work on the codebase.

KevinHock
KevinHock approved these changes Feb 12, 2020
View reviewed changes
Copy link
Collaborator

@KevinHock KevinHock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑

@OiCMudkips OiCMudkips merged commit f831d9b into Yelp:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinHock KevinHock KevinHock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OiCMudkips @KevinHock