Hand controlling TTY to child, if we have one #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51
This uses the patch from @Ehlers almost verbatim, plus adds a test.
The new behavior is that dumb-init will hand the controlling TTY to its child, if it has one. This fixes the fairly common case where running
docker run -ti <image> dumb-init bash
produces:With this change, you get job control in the shell (and no warnings printed). The test checks exactly this (outside of Docker, though).