Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate eks files #3984

Merged
merged 2 commits into from
Oct 29, 2024
Merged

validate eks files #3984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2fc29af
Update config_utils.py
kedarv Oct 29, 2024
8228293
Update test_config_utils.py
kedarv Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions paasta_tools/config_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"deploy",
"smartstack",
"cassandracluster",
"eks",
)

# this could use a better name - but basically, this is for pairs of instance types
Expand Down
2 changes: 1 addition & 1 deletion tests/test_config_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ def test_auto_config_updater_validate(mock_validate_file, all_valid, updater):
mock_validate_file.side_effect = [True, all_valid, True]

updater.write_configs("foo", "kubernetes-norcal-devc", {"a": 2})
updater.write_configs("foo", "kubernetes-pnw-devc", {"a": 2})
updater.write_configs("foo", "eks-pnw-devc", {"a": 2})
assert updater.validate() == all_valid
assert mock_validate_file.call_count == 2

Expand Down
Loading