Merge pull request #59 from Yelp/fix-58-plugin-discovery-script

Fix Gradle Portal URL in settings.gradle.kts breaking Gradle syncs
Yelp · Aug 1, 2019 · ed70186 · ed70186
2 parents 14a4279 + b8f78b9
commit ed70186
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/settings.gradle.kts b/settings.gradle.kts
@@ -40,7 +40,16 @@ fun pluginIsInstalled(): Boolean {
             .filterIsInstance<MavenArtifactRepository>()
             .any {
                 try {
-                    URL("${it.url}$path").openStream().use { stream ->
+                    // Gradle portal is exposing a wrong URL:
+                    // https://plugins.gradle.org/m2
+                    // The trailing slash is missing and this is breaking
+                    // URL composition and plugin discovery.
+                    var baseUrlString = it.url.toString()
+                    if (!baseUrlString.endsWith("/")) {
+                        baseUrlString = baseUrlString.plus("/")
+                    }
+                    val baseUrl = URL(baseUrlString)
+                    URL(baseUrl, path).openStream().use { stream ->
                         return@any stream.read() >= 0
                     }
                 } catch (ignored: java.io.IOException) {