Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Makefile targets to Gradle tasks #105
Migrate Makefile targets to Gradle tasks #105
Changes from 7 commits
4326ca2
b8ceda0
156d60c
2c5109b
353af93
b0e45e7
64e9812
1102c57
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could maybe remove the "assembleDebug" there. The "check" test below already executes
testDebugUnitTest
andtestReleaseUnitTest
so it will compile the sources for both debug and release mode.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, let's remove it 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work at the moment, as you have to specify also the
mustRunAfter
rules. In the current situation you're just saying thatpreMerge
depends onrunHooks
,:plugin:build
,:plugin:check
,assembleDebug
,check
but you're not specifying the order.This is also the reason why Travis is failing (he's running a one of a sample's
check
before thegenerateSwagger
).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was the point of this block int the root build.gradle.kts:
Except I forgot that the generated files are needed before the
compile
task 🤦♂. So at the moment I think there's a race betweencompileKotlin
andgenerateSwagger
, both being dependencies ofassembleDebug
. I hopefully fixed that here: b0e45e7#diff-392475fdf2bc320d17762ed97109a121R66